Skip to content

Commit

Permalink
Support nuclio_dashboard_url default helm chart value - "disabled" (#457
Browse files Browse the repository at this point in the history
)
  • Loading branch information
Hedingber committed Sep 30, 2020
1 parent 525ca59 commit e2af81b
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions mlrun/config.py
Expand Up @@ -249,6 +249,13 @@ def read_env(env=None, prefix=env_prefix):
):
config["httpdb"]["dsn"] = "sqlite:////mlrun/db/mlrun.db?check_same_thread=false"

# "disabled" is the helm chart default value, we don't want that value to be set cause when this value is set we
# use it in calls to the Nuclio package, and when the Nuclio package receives a value it simply uses it, and
# obviously "disabled" is not the right address.. when the Nuclio package doesn't receive a value it doing "best
# effort" to try and determine the URL, we want this "best effort" so overriding the "disabled" value
if config.get("nuclio_dashboard_url") == "disabled":
config["nuclio_dashboard_url"] = ""

if uisvc and not config.get("ui_url"):
if igz_domain:
config["ui_url"] = "https://mlrun-ui.{}".format(igz_domain)
Expand Down

0 comments on commit e2af81b

Please sign in to comment.