Skip to content

Commit

Permalink
[Requirements] Add typing-extensions explictly (#2036)
Browse files Browse the repository at this point in the history
(cherry picked from commit d914fe0)
  • Loading branch information
Hedingber committed Jun 12, 2022
1 parent 2db36db commit f12a85b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions requirements.txt
Expand Up @@ -6,6 +6,12 @@ GitPython~=3.0
aiohttp~=3.8
# 8.1.0+ breaks dask/distributed versions older than 2022.04.0, see here - https://github.com/dask/distributed/pull/6018
click~=8.0.0
# fastapi 0.78.0 requires starlette 0.19.1 which requires typing_extensions>=3.10.0
# kfp 1.8.1 requires typing-extensions>=3.7.4,<4
# for some reason when installing mlrun on a venv that already had typing-extensions==3.7.4.3 it didn't upgrade it to
# >=3.10.0 although it was installing starlette 0.19.1
# therefore adding it explictly
typing-extensions>=3.10.0,<4
# 3.0/3.2 iguazio system uses 1.0.1, but we needed >=1.6.0 to be compatible with k8s>=12.0 to fix scurity issue
# since the sdk is still mark as beta (and not stable) I'm limiting to only patch changes
kfp~=1.8.0
Expand Down
1 change: 1 addition & 0 deletions tests/test_requirements.py
Expand Up @@ -84,6 +84,7 @@ def test_requirement_specifiers_convention():
"aioitertools": {"<0.9"},
"storey": {"~=1.0.5"},
"bokeh": {"~=2.4, >=2.4.2"},
"typing-extensions": {">=3.10.0,<4"},
# These 2 are used in a tests that is purposed to test requirement without specifiers
"faker": {""},
"python-dotenv": {""},
Expand Down

0 comments on commit f12a85b

Please sign in to comment.