New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datastore] Extend Azure blob to support other auth methods #1140
Conversation
…dentials other than connection_string or account_key
…if not using Pandas, since Dask requires storage_options. Also changed line mlrun#226 from inplace=True to inplace=False. Dask does not support dropping columns inplace. Alternatively, we could test if the df is hasattr 'dask' and only apply if inplace, but this is a more general behavior.
Proposed fix for #1141 |
…ge files causes out of memory errors when loading thm back between steps
Hi @hayesgb |
@hayesgb, thank you for contributing. |
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
As a side-note, when I try to run
Do you recommend I assume this is trusted? |
@hayesgb I've never encountered this error, googling it brought up this one https://stackoverflow.com/questions/62473932/atleast-one-invalid-signature-was-encountered |
Thanks @Hedingber -- Do I need to make any additional changes at this point? Can we consider the requested |
@hayesgb - I'm fine with the changes done so far. I have some ideas for improving the test further, but no reason to block this PR for them at this point. 🎉 |
@hayesgb |
Currently, the only supported authentication methods against AzureBlobStore is AZURE_STORAGE_CONNECTION_STRING. , and possibly AZURE_STORAGE_KEY. This enables other authentication methods including use of ServicePrincipals and SAS tokens.