Fix project bugs and simplify api #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayesgb
pushed a commit
to hayesgb/mlrun
that referenced
this pull request
Jul 23, 2021
…if not using Pandas, since Dask requires storage_options. Also changed line mlrun#226 from inplace=True to inplace=False. Dask does not support dropping columns inplace. Alternatively, we could test if the df is hasattr 'dask' and only apply if inplace, but this is a more general behavior.
hayesgb
pushed a commit
to hayesgb/mlrun
that referenced
this pull request
Aug 8, 2021
…if not using Pandas, since Dask requires storage_options. Also changed line mlrun#226 from inplace=True to inplace=False. Dask does not support dropping columns inplace. Alternatively, we could test if the df is hasattr 'dask' and only apply if inplace, but this is a more general behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.