[Run] Preserve original code name/path where possible #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yaronha
commented
Jul 29, 2021
•
yaronha
commented
- in local runs try and use the original file vs create tmp (allow debug)
- copy code body to local run functions (for UI)
- when creating & running job code from code_to_function use the original py file name
- edit run output string to show UI URL or CLI commands
added 30 commits
April 27, 2021 23:48
This reverts commit 2538e36
Hedingber
suggested changes
Aug 3, 2021
|
|
||
| meta = BaseMetadata(name, project=project, tag=tag) | ||
| command, runtime = _load_func_code(command, workdir, secrets=secrets, name=name) | ||
|
|
||
| if runtime: | ||
| handler = handler or get_in(runtime, "spec.default_handler", "") | ||
| meta = BaseMetadata.from_dict(runtime["metadata"]) | ||
| meta.name = name or meta.name |
There was a problem hiding this comment.
we want the local function to have the exact same name as the job function (so in UI its the same group)
Hedingber
changed the title
Hedingber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.