[Refactor] Scrubbing mktemp calls (CVE) #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
suggested changes
Aug 29, 2021
| return tmp, model_spec, extra_dataitems | ||
| temp_path = tempfile.NamedTemporaryFile(suffix=suffix, delete=False).name | ||
| obj.download(temp_path) | ||
| return temp_path, model_spec, extra_dataitems |
There was a problem hiding this comment.
get_model is a function the client may use, you can't just add a new value in the returned tuple, that is non backwards compatible
There was a problem hiding this comment.
I did not add a new value, I renamed an existing one tmp -> temp_path
Hedingber
approved these changes
Aug 29, 2021
Hedingber
changed the title
Hedingber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tempfile.mktemp()manifests a known vulnerability wrt race condition between setting the path and obtaining the file handle, which is sometimes worrying, and pops up in security scans even when used in a safe context - https://cwe.mitre.org/data/definitions/377It is hence deemed deprecated and vulnerable: https://docs.python.org/3/library/tempfile.html#deprecated-functions-and-variables
The underlying issue here will still exist in some cases because the use case is valid - however, we will appease the scans