Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serving] Handle timeouts and retries in remote step #1476

Merged
merged 12 commits into from
Nov 11, 2021
Merged

[Serving] Handle timeouts and retries in remote step #1476

merged 12 commits into from
Nov 11, 2021

Conversation

yaronha
Copy link
Collaborator

@yaronha yaronha commented Nov 7, 2021 •
edited

  • add configurable timeout support to RemoteStep and BatchHttpRequests
  • add retries and exponential backoff support to RemoteStep and BatchHttpRequests
  • support setting Storey source arguments via serving spec params["source_args"]
  • change function endpoint default to external (ingress) IP

@yaronha yaronha changed the title [Serving] handle timeouts and retries in RemoteStep [Serving] handle timeouts and retries in remote step Nov 9, 2021
gtopper
gtopper reviewed Nov 11, 2021
View reviewed changes
mlrun/serving/remote.py Outdated Show resolved Hide resolved
mlrun/serving/remote.py Outdated Show resolved Hide resolved
@gtopper gtopper mentioned this pull request Nov 11, 2021
Closed
Hedingber
Hedingber suggested changes Nov 11, 2021
View reviewed changes
mlrun/serving/remote.py Outdated
Comment on lines 31 to 39
method_whitelist=[
"HEAD",
"GET",
"PUT",
"POST",
"DELETE",
"OPTIONS",
"TRACE",
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just setting to False ?

Set to a False value to retry on any verb

mlrun/serving/remote.py Outdated Show resolved Hide resolved
tests/serving/test_remote.py Outdated Show resolved Hide resolved
tests/serving/test_remote.py Outdated Show resolved Hide resolved
tests/serving/test_remote.py Outdated Show resolved Hide resolved
@Hedingber Hedingber changed the title [Serving] handle timeouts and retries in remote step [Serving] Handle timeouts and retries in remote step Nov 11, 2021
@Hedingber Hedingber merged commit c946ca2 into mlrun:development Nov 11, 2021
dinal pushed a commit to dinal/mlrun that referenced this pull request Nov 16, 2021
@yaronha
[Serving] Handle timeouts and retries in remote step (mlrun#1476)
c82d2ef
@yaronha yaronha deleted the serving-timeouts branch November 18, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hedingber Hedingber Hedingber requested changes

@gtopper gtopper gtopper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yaronha @gtopper @Hedingber