Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Runtimes] Fix function config compilation to not ignore .spec.build.base_image for Nuclio runtimes #1565

Merged
merged 9 commits into from
Dec 12, 2021
Merged

[Runtimes] Fix function config compilation to not ignore .spec.build.base_image for Nuclio runtimes #1565

merged 9 commits into from
Dec 12, 2021

Commits on Dec 9, 2021

  1. added prints.

    @Tankilevitch
    Tankilevitch committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    381fc83 View commit details
    Browse the repository at this point in the history

  2. added logs.

    @Tankilevitch
    Tankilevitch committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    8f28d5e View commit details
    Browse the repository at this point in the history

  3. added debug logs.

    @Tankilevitch
    Tankilevitch committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    ce9bd8c View commit details
    Browse the repository at this point in the history

  4. added build.base_image to base_image in compile_function_config.

    @Tankilevitch
    Tankilevitch committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    19b7fee View commit details
    Browse the repository at this point in the history

  5. added function.spec.build.base_image into consideration.

    @Tankilevitch
    Tankilevitch committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    74003d8 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. added tests.

    @Tankilevitch
    Tankilevitch committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    8f8b193 View commit details
    Browse the repository at this point in the history

  2. added validation if spec.image or spec.build.base_image exists.

    @Tankilevitch
    Tankilevitch committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    f2e2cfe View commit details
    Browse the repository at this point in the history

  3. linted.

    @Tankilevitch
    Tankilevitch committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    46713c2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'development' into Bug/base-image-doesnt-being-used

    @Tankilevitch
    Tankilevitch committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    862dc77 View commit details
    Browse the repository at this point in the history