Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Refactor use of pwd in Makefile + fixes #1601

Merged

Conversation

Tankilevitch
Copy link
Contributor

@Tankilevitch Tankilevitch commented Jan 2, 2022

When executing docker run using the makeFile, the $(PWD) variable is not being defined at the container runtime, to use the current working directory anyway the alternative is to use $(shell pwd).

This topic is being discussed in the following links :

Also:

  • Caching was not working for the migrations CI job because of configuration in the wrong place - fixed that
  • Added log to the openapi test

@Tankilevitch Tankilevitch reopened this Jan 2, 2022
tests/api/api/test_docs.py Outdated Show resolved Hide resolved
@Tankilevitch Tankilevitch changed the title [CI] Changed and added fully pwd compatibility when running make [CI] Refactor use of pwd in Makefile Jan 3, 2022
@Hedingber Hedingber changed the title [CI] Refactor use of pwd in Makefile [CI] Refactor use of pwd in Makefile + fixes Jan 3, 2022
@Hedingber Hedingber merged commit 0387f1a into mlrun:development Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants