[API] Fix artifact storing without project in body #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
suggested changes
Jan 6, 2022
| @@ -55,3 +55,37 @@ def test_list_artifacts_filter_by_kind(self): | |||
| project=prj, category=mlrun.api.schemas.ArtifactCategories.dataset | |||
| ) | |||
| assert len(artifacts) == 1, "bad number of dataset artifacts" | |||
|
|
|||
| def test_store_artifact_with_empty_dict(self): | |||
There was a problem hiding this comment.
We should always strive for having a functionality being tested by the fastest possible test:
- System tests are the slowest one - in order to run a test correctly you need to build a whole version out of the code, transplant it in the system etc..
- Integration tests are faster - in order to run a test you (done automatically when you run it) build a docker image of the API, run it, and do actions in the client
- Unit tests are the fastest - all you need to run them is to install all requirements
Your change here is in the API code, client is irrelevant, therefore the correct place IMO to test it is the API tests, which are unit tests that bring up a mock API inside the test process
There was a problem hiding this comment.
So you suggesting removing those tests?
Comment on lines
+27
to
+28
| if not data.setdefault("project", project): | ||
| data["project"] = project |
There was a problem hiding this comment.
If you handled the case of an empty string, I suggest that you'll cover it in the tests (maybe I missed it ?)
There was a problem hiding this comment.
added unittests
Hedingber
changed the title
|
I meant that you'll remove the integration tests, other than that LGTM |
Hedingber
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iguazeng.com/browse/ML-1322