[System Tests] Fix failing system tests as a result of none PEP 440 compatiblity #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tankilevitch
commented
Feb 15, 2022
Tankilevitch
commented
- In Enterprise and Open source system tests changes the MLRUN_VERSION that is passed to test-system-dockerized from image_tag to mlrun_version.
- Added logic in Makefile that if MLRUN_VERSION is set to image tag version then when setting MLRUN_PYTHON_PACKAGE_VERSION we modify the version to be PEP 440 compatible which in other words replace the first occurrence of "-" to "+"
Hedingber
suggested changes
Feb 15, 2022
Hedingber
suggested changes
Feb 15, 2022
Hedingber
changed the title
Hedingber
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.