Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frameworks] LightGBM module and booster MLRun interfaces for the train function #1761

Merged
merged 25 commits into from
Jul 13, 2022
Merged

[Frameworks] LightGBM module and booster MLRun interfaces for the train function #1761

merged 25 commits into from
Jul 13, 2022

Conversation

guy1992l
Copy link
Member

@guy1992l guy1992l commented Feb 17, 2022 •
edited

  • LightGBM train function is now wrapped in MLRun via LGBMMLRunInterface.
  • LightGBM Booster class for gradient boosting algorithm models is now wrapped via LGBMBoosterMLRunInterface.
  • SKLearn's interface is now the basic ML interface for XGBoost and LightGBM SKLearn's API. Should be separated as both are needed to support their own API.
  • Made per framework Utils and Types static classes.
  • Code refactoring for better type hints, docs and inheritance logic.

Future work:

  • LightGBM 'cv' function wrapped in LGBMMLRunInterface
  • Add evaluation logic post training.
  • Enhance the SKLearn's API of LightGBM to work with the evaluation metrics.

@guy1992l
Made SKLearn's MLRun interface the base interface for sklearn's API u…
11f623d 
…sage
@guy1992l
Merge branch 'development' of https://github.com/mlrun/mlrun into fra…
d33e236 
…meworks
@guy1992l
started implementing lgbm train interface
a0d05b9
@guy1992l
Merge branch 'development' of https://github.com/mlrun/mlrun into fra…
9120dcb 
…meworks
@guy1992l
Major refactoring - introducing Utils and Types
ea5c166
@guy1992l
Merge branch 'development' of https://github.com/mlrun/mlrun into fra…
d8380d2 
…meworks
@guy1992l
Added per framework Utils and Types and many refactorring
7f3154f
@guy1992l
Merge branch 'development' of https://github.com/mlrun/mlrun into fra…
b0361c9 
…meworks
@guy1992l
Creating the callbacks for LightGBM
931f8cf
@guy1992l
Merge branch 'development' of https://github.com/mlrun/mlrun into fra…
821f9b7 
…meworks
@guy1992l
Done with main training logging for lightgbm
6d94c3c
@guy1992l guy1992l changed the title [WIP][Frameworks] LightGBM module and booster MLRun interfaces [Frameworks] LightGBM module and booster MLRun interfaces for the train function Jun 26, 2022
Tankilevitch
Tankilevitch suggested changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done!!!
Added minor comments

mlrun/frameworks/_common/artifacts_library.py Show resolved Hide resolved
mlrun/frameworks/_common/mlrun_interface.py Outdated Show resolved Hide resolved
mlrun/frameworks/_common/utils.py Outdated Show resolved Hide resolved
mlrun/frameworks/_ml_common/loggers/mlrun_logger.py Outdated Show resolved Hide resolved
mlrun/frameworks/_ml_common/loggers/mlrun_logger.py Outdated Show resolved Hide resolved
mlrun/frameworks/_ml_common/loggers/mlrun_logger.py Show resolved Hide resolved
mlrun/frameworks/_ml_common/loggers/mlrun_logger.py Outdated Show resolved Hide resolved
mlrun/frameworks/lgbm/callbacks/logging_callback.py Show resolved Hide resolved
@Tankilevitch Tankilevitch merged commit 0f20cd6 into mlrun:development Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tankilevitch Tankilevitch Tankilevitch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guy1992l @Tankilevitch