[Runtimes] Divide run() method to use multiple methods
#1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
suggested changes
Feb 27, 2022
| spec = runspec.spec | ||
| if spec.secret_sources: |
There was a problem hiding this comment.
In the line above there is spec = runspec.spec which (IMO) just makes reading harder cause you're seeing spec but don't know a spec of what it is, should simply remove that and use run.spec everywhere
Same is true for meta that is defined below (let's just use run.metadata
Hedingber
approved these changes
Feb 27, 2022
Hedingber
changed the title
run() method to use multiple methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.