[Runtimes] Fix and align with_source_archive()
#1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hedingber
suggested changes
Mar 29, 2022
Hedingber
suggested changes
Apr 7, 2022
mlrun/runtimes/function.py
Outdated
Comment on lines
1329
to
1339
| def get_secrets(keys): | ||
| secrets = {} | ||
| if ( | ||
| project | ||
| and get_k8s_helper(silent=True).is_running_inside_kubernetes_cluster() | ||
| ): | ||
| secrets = function._get_k8s().get_project_secret_data(project, keys) | ||
| for key in keys: | ||
| if key in builder_env: | ||
| secrets[key] = builder_env.get(key) | ||
| return secrets |
There was a problem hiding this comment.
No reason for this to be nested, it's making it harder to read the code
You don't really need function._get_k8s() you can simply get_k8s_helper()
and you can pass it the rest of the variables
mlrun/runtimes/kubejob.py
Outdated
Comment on lines
165
to
166
| # make sure we disable load_on_run mode if the source code is in the image | ||
| build.load_source_on_run = False |
There was a problem hiding this comment.
Not sure I follow, if you build an image, why it means that the source code is in the image ?
Hedingber
changed the title
with_source_archive()
Hedingber
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.