[Datastore] Add Snowflake source #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbd86
suggested changes
Mar 28, 2022
| # V3IO does not support this level of precision | ||
| df = df.withColumn(col_name, funcs.col(col_name).cast("double")) | ||
| return df | ||
|
|
||
| def write_dataframe( | ||
| self, df, key_column=None, timestamp_key=None, chunk_id=0, **kwargs | ||
| ): | ||
| if hasattr(df, "rdd"): |
There was a problem hiding this comment.
I guess "rdd" somehow means that it is spark engine but maybe we should add a comment so it would be more straight forward
There was a problem hiding this comment.
Yeah, that's what it means... It's done in a few other places in the code base and is not affected by this PR. Feel free to PR separately.
benbd86
approved these changes
Mar 28, 2022
Hedingber
suggested changes
Mar 28, 2022
Comment on lines
+436
to
+442
| def __init__( | ||
| self, | ||
| name: str = "", | ||
| attributes: Dict[str, str] = None, | ||
| key_field: str = None, | ||
| time_field: str = None, | ||
| schedule: str = None, |
There was a problem hiding this comment.
It seems like you're not accepting all of the base class args - path, start_time and end_time are missing, is that on purpose ?
Hedingber
changed the title
xsqian
reviewed
Mar 28, 2022
| schedule=schedule, | ||
| ) | ||
|
|
||
| def get_spark_options(self): |
There was a problem hiding this comment.
Can we add an option "application": "Iguazio" which will indicate the client is from Iguazio? (for the partnership @marcelonyc knows more details about this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML-1741