Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Improve K8s installation guide #1865

Merged
merged 7 commits into from
Apr 5, 2022
Merged

[Docs] Improve K8s installation guide #1865

merged 7 commits into from
Apr 5, 2022

Conversation

george0st
Copy link
Collaborator

Improve K8s installation

Improve K8s installation
Add timeout 16 minutes (default was 5 minutes)
Location of 'quick-start.ipynb' in Jupyter is in root.
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @george0st !!
Added minor comments that could be helpful for new users.

docs/install-kubernetes.md Show resolved Hide resolved
docs/install-kubernetes.md Outdated Show resolved Hide resolved
@george0st
Copy link
Collaborator Author

@Tankilevitch, all suggestions accepted many thanks, ready for merge (the issue with 'CI/Run Dockerized Tests' has different reason).

Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Added comments about the placing of the added notes.

docs/install-kubernetes.md Outdated Show resolved Hide resolved
docs/install-kubernetes.md Outdated Show resolved Hide resolved
@george0st
Copy link
Collaborator Author

@Tankilevitch, small tuning ... looks great.

@Tankilevitch Tankilevitch changed the title [Docs] Improve K8s installation [Docs] Improve K8s installation guide Apr 5, 2022
@Tankilevitch Tankilevitch merged commit cda95ab into mlrun:development Apr 5, 2022
@Tankilevitch
Copy link
Contributor

Merged, @george0st thanks for the contribution!

@george0st george0st deleted the K8s_improvement branch April 5, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants