-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System Tests] Fix not continuing to run when one job in matrix fails #2209
[System Tests] Fix not continuing to run when one job in matrix fails #2209
Conversation
continue-on-error: true | ||
strategy: | ||
max-parallel: 1 | ||
matrix: | ||
test_component: [api,runtimes,feature_store,projects,model_monitoring,examples,demos,backward_compatibility] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use:
strategy:
fail-fast: false
You won't need that last step verify-all-system-tests-succeeded
as if one of the matrix steps fails, the job will fail but all the matrix steps will run. and continue-on-error
is mainly for the next jobs (of which there aren't any), not within the matrix. See:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
softprops/turnstyle@v1
actionfail-fast: false
.