-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Project] Change default new_project
to create instead of store
#2279
Conversation
new_project
to create instead of store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good - should verify the deletion of project when it's non-empty (cascading deletion policy is needed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we should add a system test as well, as in integration test we are testing how it will work in the community edition (mlrun
is the leader), while in Iguazio system there is a different project implementation where mlrun
is the follower and iguazio
is the leader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 😄 - the override flow should be tighter between deleting and creating (ideally this would be an atomic operation, but we should strive to have it as close to that as possible).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, nice test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work on the tests.
When creating new project allow only creation instead of update.
Add
override
option to delete existing project with the same name before creation.https://jira.iguazeng.com/browse/ML-2320