Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] Renamed decorator and made it modular #2345

Merged
merged 12 commits into from
Sep 5, 2022

Conversation

guy1992l
Copy link
Member

@guy1992l guy1992l commented Sep 5, 2022

  • The decorator was renamed to handler - function is a reserved keyword in python's builtin, and even if it wasn't the decorator do not magically turns the function into MLRun function. mlrun.handler is more accurate to the usage, as to run the function from an MLRun function, you give the function's name as a handler.
  • Auto-logging artifacts types - When logging types are not given by the user, the decorator will now log the returned object by its type according to a default map.
  • Modular and expandable - The decorator can now be enriched with further logging / parsing functions.

Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks de best!

@Tankilevitch Tankilevitch merged commit 36da873 into mlrun:development Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants