Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML images - moving packages to requirements files #269

Merged
merged 11 commits into from May 19, 2020
Merged

ML images - moving packages to requirements files #269

merged 11 commits into from May 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 19, 2020

No description provided.

@yaronha yaronha requested a review from Hedingber May 19, 2020 17:27
Copy link
Contributor

@Hedingber Hedingber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much much better now with requirements files, 🥇
See my comments

dockerfiles/base/Dockerfile Outdated Show resolved Hide resolved
dockerfiles/models-gpu/Dockerfile Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented May 19, 2020

Looks much much better now with requirements files,
See my comments

btw, defintely much much neater and convenient.

what I need to do now, is unify many of these requirements under one file, and get the conda installs better highlighted (and perhaps minimized), as there is absolutely no need for conda environments inside this type of container (single-use backing for functions).

@Hedingber Hedingber closed this May 19, 2020
@Hedingber Hedingber reopened this May 19, 2020
@ghost ghost requested a review from Hedingber May 19, 2020 21:32
@Hedingber Hedingber changed the title Docker clean ML images - moving packages to requirements files May 19, 2020
@Hedingber Hedingber merged commit ac0dde5 into mlrun:development May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants