[Projects] Notify Slack when scheduled load project failed [1.1.x] #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronha
reviewed
Dec 21, 2022
mlrun/projects/pipelines.py
Outdated
| link = f"<{url}|*view workflow job details*>" | ||
| message = ( | ||
| f":x: Project {project_name} workflow {workflow_name}" | ||
| f" failed to run scheduling workflow remotely!\n{link}" |
There was a problem hiding this comment.
please add the error text message
quaark
requested changes
Dec 21, 2022
| ) | ||
| except Exception as error: | ||
| # Notifying to slack in case of scheduling: | ||
| slack = RunNotifications(with_slack=True) |
There was a problem hiding this comment.
Please add a TODO to change this to the new notifications once they are merged
There was a problem hiding this comment.
@quaark once this is merged @yonishelach will do the PR into 1.2.1 with the new mechanism
quaark
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
message example:
