Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration tests #316

Merged
merged 7 commits into from
Jun 16, 2020

Conversation

Hedingber
Copy link
Contributor

  • minimize env vars required for integration test
  • add this code snippet wherever ! is being used in the notebooks so the cell execution (and as an outcome the test) will fail if the command execution failed
if _exit_code != 0:
    raise RuntimeError()
  • change wait_for_pipeline_completion default expected_statuses to be [ Succeeded ] (was empty) and other correctness and docs changes for this function
  • use wait_for_pipeline_completion in the test notebooks so that test will fail when the pipeline fail (and will succeed only after pipeline finished successfully)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@yaronha yaronha merged commit a58e98b into mlrun:development Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants