New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add v1.3.0 change log #3194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went over the change-log
docs/change-log/index.md
Outdated
|
||
|
||
|
||
- The base images mlrun/mlrun:1.3.0 etc. are based on python 3.9. <br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is under the Client/server matrix
section due to the fact that the MLRun server is now 3.9-based (which is not written here, this just mentions the mlrun images), and we recommend moving the client to 3.9 as well. This is what these steps are for, and I think it makes sense to explain it.
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Tom Tankilevitch <59158507+Tankilevitch@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improvements below
docs/change-log/index.md
Outdated
- Fix: UI Projects' metrics show N/A for all projects when ml-pipeline is down. [View in Git](https://github.com/mlrun/ui/pull/1613). | ||
- `project.list_models()` did not function as expected for tags and labels. The `list_artifacts` method now accept a dictionary, and | ||
docstrings were added for httpdb and for MLRunProject methods: both `list_artifacts` and `list_models`. [View in Git](https://github.com/mlrun/mlrun/pull/2988). | ||
- Fix: Failed MLRun Nuclio deploy needs better error messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Co-authored-by: Liran BG <liranbg@users.noreply.github.com>
Co-authored-by: Liran BG <liranbg@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Mainly comments about what we talked about offline.
…Order open and closed issues numerically,
- **engine** — processing engine kind ("local", "dask", or "spark") | ||
- **engine_args** — kwargs for the processing engine | ||
- **query** — The query string used to filter rows | ||
- **spark_service** — Name of the spark service to be used (when using a remote-spark runtime) | ||
- **join_type** — (optional) Indicates the join type: `{'left', 'right', 'outer', 'inner'}, default 'outer'`. Relevant only for Dask and storey (local) engines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default is "inner", not "outer".
also "local" is pandas, not storey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
No description provided.