Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add v1.3.0 change log #3194

Merged
merged 53 commits into from Mar 15, 2023
Merged

[Docs] Add v1.3.0 change log #3194

merged 53 commits into from Mar 15, 2023

Conversation

jillnogold
Copy link
Member

No description provided.

Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over the change-log




- The base images mlrun/mlrun:1.3.0 etc. are based on python 3.9. <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is under the Client/server matrix section due to the fact that the MLRun server is now 3.9-based (which is not written here, this just mentions the mlrun images), and we recommend moving the client to 3.9 as well. This is what these steps are for, and I think it makes sense to explain it.

docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
jillnogold and others added 9 commits March 1, 2023 16:34
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Co-authored-by: Saar Cohen <66667568+theSaarco@users.noreply.github.com>
Copy link
Member

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvements below

docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
- Fix: UI Projects' metrics show N/A for all projects when ml-pipeline is down. [View in Git](https://github.com/mlrun/ui/pull/1613).
- `project.list_models()` did not function as expected for tags and labels. The `list_artifacts` method now accept a dictionary, and
docstrings were added for httpdb and for MLRunProject methods: both `list_artifacts` and `list_models`. [View in Git](https://github.com/mlrun/mlrun/pull/2988).
- Fix: Failed MLRun Nuclio deploy needs better error messages.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing pr

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Mainly comments about what we talked about offline.

docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
docs/change-log/index.md Outdated Show resolved Hide resolved
- **engine** &mdash; processing engine kind ("local", "dask", or "spark")
- **engine_args** &mdash; kwargs for the processing engine
- **query** &mdash; The query string used to filter rows
- **spark_service** &mdash; Name of the spark service to be used (when using a remote-spark runtime)
- **join_type** &mdash; (optional) Indicates the join type: `{'left', 'right', 'outer', 'inner'}, default 'outer'`. Relevant only for Dask and storey (local) engines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default is "inner", not "outer".
also "local" is pandas, not storey

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@liranbg liranbg merged commit 916512f into mlrun:development Mar 15, 2023
liranbg pushed a commit to liranbg/mlrun that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants