[Local] Support passing more parameters to handler if handler contains **kwargs keyword
#3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonmr
reviewed
May 14, 2023
theSaarco
requested changes
May 14, 2023
mlrun/runtimes/local.py
Outdated
| kwargs[key] = copy(params[key]) | ||
| for key in inputs: | ||
| if key not in kwargs: | ||
| kwargs[key] = context.get_input(key, inputs[key]) |
There was a problem hiding this comment.
The input processing above has more to it (using obj.local() in some cases) - maybe have that piece of logic in an internal function, and use it here as well. Or did you verify this is dead code in which case I would remove it there as well?
guy1992l
approved these changes
May 14, 2023
mlrun/runtimes/local.py
Outdated
|
|
||
| # VAR_KEYWORD meaning : A dict of keyword arguments that aren’t bound to any other parameter. | ||
| # This corresponds to a **kwargs parameter in a Python function definition. | ||
| if any(param.kind == param.VAR_KEYWORD for param in args.values()): |
There was a problem hiding this comment.
args = inspect.signature(handler).parameters means that args is an OrderedDict and because **kwargs can only be last in the function's parameters list, you can simply check the last one:
Suggested change
| if any(param.kind == param.VAR_KEYWORD for param in args.values()): | |
| if list(args.values())[-1].kind == param.VAR_KEYWORD: |
alonmr
reviewed
May 14, 2023
mlrun/runtimes/local.py
Outdated
Comment on lines
480
to
481
| else: | ||
| return context.get_input(input_key, inputs[input_key]) |
There was a problem hiding this comment.
I believe it's the same
Suggested change
| else: | |
| return context.get_input(input_key, inputs[input_key]) | |
| return input_obj |
tests/run/test_run.py
Outdated
| @@ -142,6 +142,32 @@ def test_local_runtime_failure_before_executing_the_function_code(db): | |||
| assert "failed on pre-loading" in str(exc.value) | |||
|
|
|||
|
|
|||
| def test_local_runtime_with_kwargs(db): | |||
There was a problem hiding this comment.
would be nice if you could add some more test cases for example:
- if kwargs is empty
- if params is empty
- if param x is in kwargs
liranbg
reviewed
May 14, 2023
mlrun/runtimes/local.py
Outdated
| kwargs[key] = _get_input_value(key) | ||
|
|
||
| # get the last parameter, as **kwargs can only be last in the function's parameters list | ||
| last_param = list(args.values())[-1] |
alonmr
approved these changes
May 15, 2023
Tankilevitch
added a commit
to Tankilevitch/mlrun
that referenced
this pull request
May 22, 2023
…s `**kwargs` keyword (mlrun#3533) (cherry picked from commit 00d1719)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iguazeng.com/browse/ML-3761