[Runtime] Fix run type hints
#3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
reviewed
May 23, 2023
mlrun/runtimes/base.py
Outdated
| auto_build=None, | ||
| param_file_secrets: Dict[str, str] = None, | ||
| notifications: List[mlrun.model.Notification] = None, | ||
| runspec: Optional[Union["mlrun.run.RunTemplate", "mlrun.run.RunObject"]] = None, |
There was a problem hiding this comment.
how come we can pass a concrete and one time a template? can you perhaps elaborate on function docstring when such cases occurs?
There was a problem hiding this comment.
RunTemplate is essentially a RunObject without a status. We generate a RunObject from whatever is given.
We generate a run object from the template if a RunTemplate is given.
It helped me find some other problems - we also allow dict and there was _create_run_object in BaseRuntime that we forgot to delete
Tankilevitch
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the type hints for
runandlaunchmethods.rusnpec / task can also be a RunTemplate.
handler can be either str or callable for dask and handler runtimes.
add optional where missing.
removed duplicated typing import (using
fromnotation with typing because it is overwhelming to have a full notation for methods likerunandlaunchwith many parameters)