[API] Fix get pipelines return code in case of nonexistent project #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
suggested changes
May 23, 2023
There was a problem hiding this comment.
Looking at the logic that is being "catched" it seems quite weird that if we don't find that pipeline under the requested project we return MLRunInvalidArgumentError which returns 400, while I would expect to get 404 which is the mlrun error - MLRunNotFoundError.
please adjust it as well
Tankilevitch
suggested changes
May 23, 2023
There was a problem hiding this comment.
Looking at the logic that is being "catched" it seems quite weird that if we don't find that pipeline under the requested project we return MLRunInvalidArgumentError which returns 400, while I would expect to get 404 which is the mlrun error - MLRunNotFoundError.
please adjust it as well
Signed-off-by: Yan Burman <yanburman@users.noreply.github.com>
liranbg
approved these changes
May 25, 2023
Tankilevitch
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iguazeng.com/browse/ML-1267