[Model Monitoring] Fix event error message in monitoring stream graph #3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assaf758
requested changes
May 24, 2023
gtopper
approved these changes
May 28, 2023
liranbg
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for https://jira.iguazeng.com/browse/ML-3791.
When there is an error in the event dictionary, the monitoring stream graph returns
Noneinstead of raising an exception with the related error information. As a result, instead of getting the correct error information, the monitoring stream pod raise an error fromStoreythat can't handle aNoneevent object.In this PR we fix this issue and raise the correct error event description instead of returning a
Noneobject. Therefore, storey will push the right error message to the error stream and the monitoring stream will log the right error message as expected.