Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Install requirements using pip --upgrade #3652

Merged
merged 2 commits into from
May 28, 2023

Conversation

TomerShor
Copy link
Member

Sometimes when a user gives requirements that are already present in the base image, pip doesn't install them, since it didn't consider it an update.

In this PR we run pip --upgrade when deploying installing requested by the user, as these are specifically requested by the user so we should make an effort to install the user's version.

Resolves https://jira.iguazeng.com/browse/ML-3859

Copy link
Member

@theSaarco theSaarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you have a lot of unit tests failing since they expect pip commands that are now different...

Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tankilevitch Tankilevitch merged commit 50d2733 into mlrun:development May 28, 2023
14 checks passed
@TomerShor TomerShor deleted the ML-3859-reqs-pip-u branch May 28, 2023 14:16
alonmr added a commit that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants