[Builder] Install mlrun with python requirements #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranbg
requested changes
May 31, 2023
mlrun/api/utils/builder.py
Outdated
|
|
||
| # mlrun must be installed with other python requirements in the same pip command to avoid version conflicts | ||
| if mlrun_version: | ||
| requirements_list = [mlrun_version] + requirements_list |
There was a problem hiding this comment.
Suggested change
| requirements_list = [mlrun_version] + requirements_list | |
| requirements_list.insert(0, mlrun_version) |
There was a problem hiding this comment.
funny, that's what I did at first but then I thought that the other way is more readable.
fixed
liranbg
approved these changes
May 31, 2023
Tankilevitch
suggested changes
May 31, 2023
There was a problem hiding this comment.
good pr and nice test coverage overall.
But I think as we already discussed in your previous PR, there is a scenario where a user can pass with_mlrun=True but we change it to with_mlrun=False if we see that the image is one of ours (mlrun/mlrun or mlrun/ml-models etc..). Now I think that we should add the mlrun requirement any way if there are other requirements as well as part of the build so that the requirements will be installed all together.
theSaarco
reviewed
May 31, 2023
Tankilevitch
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to install mlrun in the same command as with all other python packages so that pip will take into consideration the mlrun requirements.
Implementation: