[API] Resolve function URI when submitting a schedule from hub function #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tankilevitch
changed the title
Tankilevitch
changed the title
Tankilevitch
changed the title
Tankilevitch
changed the title
alonmr
reviewed
Jun 1, 2023
| assert len(schedules) == 1 | ||
|
|
||
| schedule = schedules[0] | ||
| assert schedule["scheduled_object"]["task"]["spec"]["function"] != hub_function_uri |
There was a problem hiding this comment.
I suggest using a regex to see the function uri is as expected ({project}/{name}@{hash}:{tag})
| # if the task is pointing to a remote function (hub://), we need to save it to the db | ||
| # and update the task to point to the saved function, so that the scheduler will be able to | ||
| # access the db version of the function, and not the remote one (which can be changed between runs) | ||
| if "://" in task["spec"]["function"]: |
There was a problem hiding this comment.
what if the function points to db? (db://)
| function_uri = fn.save(versioned=True) | ||
| data.pop("function", None) | ||
| data.pop("function_url", None) | ||
| task["spec"]["function"] = function_uri.replace("db://", "") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.iguazeng.com/browse/ML-3933
Full details for the fix inside the code and the ticket