[API] Fix files API to work on non-k8s environments
#3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quaark
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Spoke with @theSaarco offline, we agreed the existing log is enough
alonmr
reviewed
Jul 11, 2023
There was a problem hiding this comment.
The fix is one step in the right direction but IIRC there are more places that we access the k8s helper when not running in k8s and we explode (see #3444)
For example submit_run_sync
Maybe see if you can find more places where this is needed
theSaarco
added a commit
that referenced
this pull request
Jul 11, 2023
guy1992l
pushed a commit
to guy1992l/mlrun
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
filesAPI retrieves project secrets before accessing files, to enable access to stores that need credentials. In a situation where MLRun service is not running on k8s (Docker, local deployments), this would explode.Added a check to verify first that we're running inside a k8s cluster. If we're not, the file will be retrieved without attempting to get project secrets for authentication.