Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Store] Fix missing "created" status from the UI #3927

Merged
merged 6 commits into from Jul 19, 2023

Conversation

jond01
Copy link
Member

@jond01 jond01 commented Jul 12, 2023

Resolves ML-3939.

Fix a discrepancy between feature stores generated from the UI compared to the SDK.

See also #3813, which solved a similar issue.

Tests:

@jond01 jond01 changed the title [Bug]: Add "created" to feature stores from the UI [Bug] Add "created" to feature stores from the UI Jul 12, 2023
@jond01 jond01 changed the title [Bug] Add "created" to feature stores from the UI [Feature Store] Fix missing "created" status from the UI Jul 12, 2023
yanburman and others added 3 commits July 16, 2023 11:06
Signed-off-by: Yan Burman <yanburman@users.noreply.github.com>
Test only the new logic
@jond01 jond01 marked this pull request as ready for review July 16, 2023 13:30
Copy link
Contributor

@davesh0812 davesh0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@assaf758 assaf758 merged commit fb5af25 into mlrun:development Jul 19, 2023
12 checks passed
@jond01 jond01 deleted the jond01/ml-3939 branch July 19, 2023 08:32
guy1992l pushed a commit to guy1992l/mlrun that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants