Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLRun Errors + v3io access forbidden uses errors #393

Merged
merged 4 commits into from Aug 10, 2020
Merged

MLRun Errors + v3io access forbidden uses errors #393

merged 4 commits into from Aug 10, 2020

Conversation

quaark
Copy link
Member

@quaark quaark commented Aug 6, 2020

  • Added errors.py to mlrun.
  • The errors are built in a way that they can be used as HTTP errors with a custom raise_for_status(response) function, or just regular errors that aren't HTTP.

Used the errors in:

  • When using /files or /filestat, if user is unauthorised to access the files in the v3io container, return a 403 status code

@quaark quaark changed the title MLRun Errors + v3io access forbidden uses errors [WIP] MLRun Errors + v3io access forbidden uses errors Aug 6, 2020
@quaark quaark changed the title [WIP] MLRun Errors + v3io access forbidden uses errors MLRun Errors + v3io access forbidden uses errors Aug 6, 2020
Hedingber
Hedingber suggested changes Aug 9, 2020
View reviewed changes
mlrun/errors.py Show resolved Hide resolved
tests/test_datastores.py Outdated Show resolved Hide resolved
mlrun/api/api/endpoints/files.py Outdated Show resolved Hide resolved
mlrun/api/api/endpoints/files.py Outdated Show resolved Hide resolved
@Hedingber Hedingber requested a review from omesser August 9, 2020 23:39
omesser
omesser suggested changes Aug 10, 2020
View reviewed changes
mlrun/api/api/endpoints/files.py Outdated Show resolved Hide resolved
mlrun/datastore/v3io.py Outdated Show resolved Hide resolved
mlrun/datastore/v3io.py Outdated Show resolved Hide resolved
mlrun/datastore/v3io.py Outdated Show resolved Hide resolved
mlrun/errors.py Outdated Show resolved Hide resolved
mlrun/errors.py Show resolved Hide resolved
mlrun/errors.py Outdated Show resolved Hide resolved
tests/test_datastores.py Outdated Show resolved Hide resolved
mlrun/errors.py Outdated Show resolved Hide resolved
omesser
omesser approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@omesser omesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat!

@Hedingber Hedingber merged commit 28eaceb into mlrun:development Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omesser omesser omesser approved these changes

@Hedingber Hedingber Hedingber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@quaark @omesser @Hedingber