Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications] Add Webhook notification type #3946

Merged
merged 2 commits into from Jul 18, 2023

Conversation

quaark
Copy link
Member

@quaark quaark commented Jul 18, 2023

Add Webhook notification implementation to the notification mechanism.

Users will be able to supply in notification params:

  • url: The webhook url to which to send the notification.
  • method: The http method to use when sending the notification (GET, POST, PUT, etc...).
  • headers: (dict) The http headers to send with the notification.
  • override_body: (dict) The body to send with the notification. If not specified, the body will be a dict with the name, message, severity, and the runs

@quaark quaark changed the title [Notifications] Add Webhook & Mlrun Job notification types [Notifications] Add Webhook notification type Jul 18, 2023
@quaark quaark marked this pull request as ready for review July 18, 2023 08:14
Copy link
Member

@alonmr alonmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@quaark quaark merged commit 4af88a9 into mlrun:development Jul 18, 2023
12 checks passed
guy1992l pushed a commit to guy1992l/mlrun that referenced this pull request Jul 25, 2023
* webhook notification

* docs

---------

Co-authored-by: quaark <a.melnick@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants