Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#437 introduced a new
version_file.py
script that used to create/update the version file.This script is being run in the
update-version-file
makefile target, which is a dependency of every step that is building something (images/package).Running this script requires to python3.7 and the
automation/requirements.txt
to be installed, so:I thought that although it will add some time (building an image and running it >> running python script) it worth moving this script to be ran dockerized when running it the from the
update-version-file
makefile targetI also fixed some logging issues (logging simply didn't work)