Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run update-version-file in docker #443

Merged
merged 6 commits into from Sep 22, 2020

Conversation

Hedingber
Copy link
Contributor

@Hedingber Hedingber commented Sep 22, 2020

#437 introduced a new version_file.py script that used to create/update the version file.
This script is being run in the update-version-file makefile target, which is a dependency of every step that is building something (images/package).
Running this script requires to python3.7 and the automation/requirements.txt to be installed, so:

  1. we needed to add several setup tests to the CI in several places
  2. If you want to clone the repo and build some image you now can't - you need to do the above setup steps
    I thought that although it will add some time (building an image and running it >> running python script) it worth moving this script to be ran dockerized when running it the from the update-version-file makefile target

I also fixed some logging issues (logging simply didn't work)

Copy link
Member

@quaark quaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hedingber Hedingber merged commit 15bfc20 into mlrun:development Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants