Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use container with docker, python and git for building images #458

Merged
merged 1 commit into from Oct 1, 2020
Merged

CI: use container with docker, python and git for building images #458

merged 1 commit into from Oct 1, 2020

Conversation

orkiguazio
Copy link
Contributor

No description provided.

Hedingber
Hedingber suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@Hedingber Hedingber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use that container for all build steps, not just api.
As we talked offline, this container should have git as well, otherwise it won't work

orkiguazio
orkiguazio commented Sep 30, 2020
View reviewed changes
Copy link
Contributor Author

@orkiguazio orkiguazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All build steps are being executed in this same container....

@Hedingber Hedingber changed the title use docker-python container in api stage CI: use container with docker, python and git for building images Oct 1, 2020
@Hedingber Hedingber merged commit bfe974a into development Oct 1, 2020
@Hedingber Hedingber deleted the _fix_api_ci branch December 10, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hedingber Hedingber Hedingber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orkiguazio @Hedingber