New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2 model serving (and refactor serving as dir) #463
Conversation
… ver for back comp)
…ving # Conflicts: # mlrun/runtimes/function.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaronha - A lot of repeating stuff:
- Naming conventions - it is NOT ok to give one char names to variables
e
can beevent
error
exception
env
I can not and should not guess what's in there. - characters don't cost money, please use full names
function
and notf
fu
orfn
- string formatting - use
f"some string {some_variable}"
instead of"some string {0}".format(some_variable)
- logging - use variables logging and not string formatting:
logger.info("Some log message", some_variable=some_variable)
instead oflogger.info(f"Some log message: {some_variable}")
- Prefer using constants instead of the same reapeted hard coded string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaronha there are still plenty of unresolved comments from the previous review
Added some new comments.
Generally, there are tons of lines of codes here, very hard to understand the hierarchy between the different classes, please add some explanation in the PR description
this PR creates a new serving framework for models (but not limited running models), it comes with a special
serving
runtime (based on Nuclio) and follow common serving APIs (based on KFServing v2 and Triton), the serving framework supports complex topologies defined through a states graph (similar to AWS Step Functions), see more in the doc atmlrun/serving/README.md