Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 model serving (and refactor serving as dir) #463

Merged
merged 52 commits into from Oct 12, 2020

Conversation

yaronha
Copy link
Collaborator

@yaronha yaronha commented Oct 3, 2020

this PR creates a new serving framework for models (but not limited running models), it comes with a special serving runtime (based on Nuclio) and follow common serving APIs (based on KFServing v2 and Triton), the serving framework supports complex topologies defined through a states graph (similar to AWS Step Functions), see more in the doc at mlrun/serving/README.md

@yaronha yaronha requested a review from Hedingber October 5, 2020 11:25
@Hedingber Hedingber changed the title add v2 model serving (and refact serving as dir) Add v2 model serving (and refactor serving as dir) Oct 7, 2020
Copy link
Contributor

@Hedingber Hedingber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronha - A lot of repeating stuff:

  • Naming conventions - it is NOT ok to give one char names to variables e can be event error exception env I can not and should not guess what's in there.
  • characters don't cost money, please use full names function and not f fu or fn
  • string formatting - use f"some string {some_variable}" instead of "some string {0}".format(some_variable)
  • logging - use variables logging and not string formatting: logger.info("Some log message", some_variable=some_variable) instead of logger.info(f"Some log message: {some_variable}")
  • Prefer using constants instead of the same reapeted hard coded string

mlrun/__main__.py Outdated Show resolved Hide resolved
mlrun/__main__.py Outdated Show resolved Hide resolved
mlrun/__main__.py Outdated Show resolved Hide resolved
mlrun/__main__.py Outdated Show resolved Hide resolved
mlrun/__main__.py Outdated Show resolved Hide resolved
mlrun/serving/server.py Outdated Show resolved Hide resolved
tests/test_serving.py Outdated Show resolved Hide resolved
mlrun/serving/v1_serving.py Outdated Show resolved Hide resolved
mlrun/serving/server.py Show resolved Hide resolved
tests/test_serving.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Hedingber Hedingber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronha there are still plenty of unresolved comments from the previous review
Added some new comments.
Generally, there are tons of lines of codes here, very hard to understand the hierarchy between the different classes, please add some explanation in the PR description

mlrun/runtimes/serving.py Outdated Show resolved Hide resolved
mlrun/runtimes/serving.py Outdated Show resolved Hide resolved
mlrun/runtimes/serving.py Outdated Show resolved Hide resolved
mlrun/runtimes/serving.py Outdated Show resolved Hide resolved
mlrun/runtimes/serving.py Outdated Show resolved Hide resolved
mlrun/serving/states.py Show resolved Hide resolved
mlrun/serving/v2_serving.py Outdated Show resolved Hide resolved
mlrun/serving/v2_serving.py Show resolved Hide resolved
mlrun/serving/v2_serving.py Outdated Show resolved Hide resolved
tests/serving/test_serving.py Outdated Show resolved Hide resolved
@Hedingber Hedingber merged commit 0d1f04d into mlrun:development Oct 12, 2020
@yaronha yaronha deleted the v2-serving branch September 7, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants