Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Adding Dataset usage examples #469

Merged
merged 6 commits into from
Oct 25, 2020

Conversation

gilad-shaham
Copy link
Member

Added some documentation of dataset usage
Also some minor fixes to the documentation

Copy link
Contributor

@Hedingber Hedingber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Thanks for putting effort on improving the docs
Some minor comments

Comment on lines +72 to +73
project=project_name,
artifact_path=artifact_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two variables aren't defined

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/data-management-and-versioning.md Outdated Show resolved Hide resolved
from mlrun.mlutils import gcf_clear

gcf_clear(plt)
cmd = metrics.plot_confusion_matrix(model, xtest, ytest, normalize='all', values_format = '.2g', cmap=plt.cm.Blues)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does cmd means ?
The only thing I can think of is shortcut of command which I don't understand how it's related to the context
we can probably find a better naming

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from mlutils.eval_class_mode. I'll change the name here so it's clearer (likely the original meaning is confusion matrix diagram)

docs/job-submission-and-tracking.md Outdated Show resolved Hide resolved
gilad-shaham and others added 3 commits October 22, 2020 15:09
Co-authored-by: Hedingber <hedingber@gmail.com>
Co-authored-by: Hedingber <hedingber@gmail.com>
@Hedingber Hedingber changed the title Documentation: dataset usage [docs] Adding Dataset usage examples Oct 25, 2020
@Hedingber Hedingber merged commit 7d2bbc8 into mlrun:development Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants