-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Adding Dataset usage examples #469
[docs] Adding Dataset usage examples #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for putting effort on improving the docs
Some minor comments
project=project_name, | ||
artifact_path=artifact_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two variables aren't defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
from mlrun.mlutils import gcf_clear | ||
|
||
gcf_clear(plt) | ||
cmd = metrics.plot_confusion_matrix(model, xtest, ytest, normalize='all', values_format = '.2g', cmap=plt.cm.Blues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does cmd means ?
The only thing I can think of is shortcut of command which I don't understand how it's related to the context
we can probably find a better naming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took it from mlutils.eval_class_mode. I'll change the name here so it's clearer (likely the original meaning is confusion matrix diagram)
Co-authored-by: Hedingber <hedingber@gmail.com>
Co-authored-by: Hedingber <hedingber@gmail.com>
Changed iris_dataset.csv path
Added some documentation of dataset usage
Also some minor fixes to the documentation