Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boto3 dependency #486

Merged
merged 3 commits into from
Oct 21, 2020
Merged

Fix boto3 dependency #486

merged 3 commits into from
Oct 21, 2020

Conversation

Hedingber
Copy link
Contributor

@Hedingber Hedingber commented Oct 21, 2020

So far the dependency was defined as boto3>=1.9, recently boto3 1.16 was released, which requires botocore >=1.19.0, which requires urllib3>=1.25.4,<1.26 which conflicting ours urllib3>=1.24.2, <1.25
So added upbound for boto3: boto3>=1.9, <1.16

This was causing errors such as:
botocore 1.19.2 requires urllib3<1.26,>=1.25.4; python_version != "3.4", but you'll have urllib3 1.24.3 which is incompatible. when installing MLRun
And also caused this error in our CI:

ImportError while loading conftest '/mlrun/tests/conftest.py'.
tests/conftest.py:50: in <module>
    from mlrun.api.db.sqldb.db import run_time_fmt  # noqa: E402
mlrun/__init__.py:29: in <module>
    from .datastore import DataItem
mlrun/datastore/__init__.py:17: in <module>
    from .datastore import StoreManager, uri_to_ipython, get_object_stat, in_memory_store
mlrun/datastore/datastore.py:22: in <module>
    from .s3 import S3Store
mlrun/datastore/s3.py:15: in <module>
    import boto3
/usr/local/lib/python3.7/site-packages/boto3/__init__.py:16: in <module>
    from boto3.session import Session
/usr/local/lib/python3.7/site-packages/boto3/session.py:17: in <module>
    import botocore.session
/usr/local/lib/python3.7/site-packages/botocore/session.py:30: in <module>
    import botocore.credentials
/usr/local/lib/python3.7/site-packages/botocore/credentials.py:34: in <module>
    from botocore.config import Config
/usr/local/lib/python3.7/site-packages/botocore/config.py:16: in <module>
    from botocore.endpoint import DEFAULT_TIMEOUT, MAX_POOL_CONNECTIONS
/usr/local/lib/python3.7/site-packages/botocore/endpoint.py:22: in <module>
    from botocore.awsrequest import create_request_object
/usr/local/lib/python3.7/site-packages/botocore/awsrequest.py:25: in <module>
    import botocore.utils
/usr/local/lib/python3.7/site-packages/botocore/utils.py:30: in <module>
    from urllib3.util.url import IPV6_ADDRZ_RE
E   ImportError: cannot import name 'IPV6_ADDRZ_RE' from 'urllib3.util.url' (/usr/local/lib/python3.7/site-packages/urllib3/util/url.py)

here's the related botocore issue - boto/botocore#2187

@Hedingber Hedingber merged commit 7bdbf3e into mlrun:development Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant