[API] Check background task state on project deletion wait [1.6.x] #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
reviewed
Feb 12, 2024
Comment on lines
+1006
to
+1007
| # We only test igz version < 3.5.5 flow because from 3.5.5 iguazio waits for the inner background task to | ||
| # finish so the wrapper task does not wait for the inner task |
There was a problem hiding this comment.
isn't the fail fast what you are testing? so it happens only for 3.5.5, no?
There was a problem hiding this comment.
We only wait for the project deletion on iguazio < 3.5.5.
From iguazio 3.5.5 zebo waits for the inner bg task so the wrapper task waits on the zebo job and we know that if the zebo job succeeded/failed then the inner bg task finished. Therfore there is nothing to test on igz 3.5.5 because the flow doesn't reach the wait for deletion part.
# Conflicts: # server/api/crud/projects.py
alonmr
added a commit
to alonmr/mlrun
that referenced
this pull request
Feb 12, 2024
…lrun#5104) (cherry picked from commit afecd24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.iguazeng.com/browse/ML-5701
Fail fast when the background task failed instead of waiting for 30 mins for nothing.