[Projects] Fix second create_remote not overriding current remote #5245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Looking good!
I think there is no real reason to have both create_remote and set_remote, as they provide the same functionality but with an extra feature in set.
We can maybe deprecate create_remote (add deprecation warning and remove in 2 versions), and encourage users to use only set_remote.
TomerShor
changed the title
quaark
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Spoke with @yaelgen offline, I feel a better solution instead of changing create to set (with override defaulting to False), we should extend the API to include create (never overrides), set (override defaults to True and can be set to False) and remove
TomerShor
requested changes
Mar 12, 2024
liranbg
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: ML-5079