Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model Monitoring] Test and Fix for Model-monitoring data-path: support LLM/deep-learning models #5289

Merged
merged 6 commits into from Mar 20, 2024

Conversation

davesh0812
Copy link
Contributor

@davesh0812 davesh0812 commented Mar 14, 2024

Implements and test ML-5459

One important change : no more saving prediction as a vec or as a dict to the parquet (no one used it), only each port to separated column according to the model schema (if there is no schema the stream pod generated it).

Copy link
Member

@assaf758 assaf758 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comment inline.
Still need to check if it helps for BC to save empty list/dict

tests/system/model_monitoring/test_app.py Outdated Show resolved Hide resolved
mlrun/model_monitoring/controller.py Show resolved Hide resolved
@assaf758 assaf758 merged commit 0cfbc03 into mlrun:development Mar 20, 2024
10 checks passed
davesh0812 added a commit to davesh0812/mlrun that referenced this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants