Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add/update model monitoring #5401

Merged
merged 45 commits into from
May 28, 2024

Conversation

jillnogold
Copy link
Member

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

docs/monitoring/model-monitoring.md Outdated Show resolved Hide resolved
docs/monitoring/model-monitoring.md Outdated Show resolved Hide resolved
docs/monitoring/model-monitoring.md Outdated Show resolved Hide resolved
docs/monitoring/model-monitoring.md Outdated Show resolved Hide resolved
docs/monitoring/monitoring-models.ipynb Show resolved Hide resolved
docs/monitoring/untitled Outdated Show resolved Hide resolved
docs/tutorials/05-model-monitoring.ipynb Outdated Show resolved Hide resolved
docs/tutorials/05-model-monitoring.ipynb Outdated Show resolved Hide resolved
docs/tutorials/05-model-monitoring.ipynb Show resolved Hide resolved
@amit-elbaz
Copy link

amit-elbaz commented May 1, 2024

Hi, I wanted to add that this PR looks great, the documentation is very detailed about all the capabilities of the model monitoring!

However, I think that we miss some examples of applications that can be used in the new model monitoring. Since the new model monitoring is based on user defined applications, it will be helpful to provide some examples that show how the application function should look like (it needs to have fixed parameters and return some fixed values).
I will add 2 examples notebook that I used when I was asked to test it. Feel free to use any part of it or take inspiration from them. Just note that:

  • One notebook uses Evidently in the application function to perform the model monitoring.
  • The second one also uses Evidently in the application function, but it tested how to monitor LLM models. So the Evidently monitoring is more 'basic' as we just wanted to test if there is a way to monitor 'text' data since it's LLM. The notebook also contains some workaround that is the process of being solved (or maybe it's already solved) - it logs a 'dummy' model to create a model endpoint. This won't be needed in the future.

If you need any more info about the new model monitoring and the applications- I can try to help but @Eyal-Danieli is the address

Examples in here https://mckinsey.box.com/s/r8ovuiu8bywtkdq2kfqpeqln9lfswqzy

@jillnogold
Copy link
Member Author

@amit-elbaz Are your comments all relevant to v1.6? I want to get the first updates out soon, and then update for 1.7.
Thanks

@amit-elbaz
Copy link

@jillnogold I think this starts in 1.7. @Eyal-Danieli Can you confirm?

Copy link
Member

@Eyal-Danieli Eyal-Danieli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a single comment

docs/tutorials/05-model-monitoring.ipynb Outdated Show resolved Hide resolved
@assaf758 assaf758 merged commit b9dbe97 into mlrun:development May 28, 2024
11 checks passed
assaf758 pushed a commit to assaf758/mlrun that referenced this pull request May 28, 2024
rokatyy pushed a commit to rokatyy/mlrun that referenced this pull request May 28, 2024
@jillnogold jillnogold deleted the ml-5883-model-monitoring branch June 6, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants