[Feature Store] Read optimisation on partitioned target #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CSVTarget and DFTarget
…CSVSource, dataframeSource and BigQuerySource
only in parquetsource or parquettarget.
gtopper
changed the title
gtopper
requested changes
Apr 30, 2024
Co-authored-by: Gal Topper <gal.topper@gmail.com>
gtopper
reviewed
May 1, 2024
gtopper
requested changes
May 1, 2024
mlrun/feature_store/api.py
Outdated
| @@ -175,6 +176,14 @@ def get_offline_features( | |||
| By default, the filter executes on the timestamp_key of each feature set. | |||
| Note: the time filtering is performed on each feature set before the | |||
| merge process using start_time and end_time params. | |||
| :param additional_filters: (list of tuples, optional): List of additional_filters conditions as tuples. | |||
There was a problem hiding this comment.
Would be nice to follow the convention of how we specify type and optionality in the rest of the code base. I guess there isn't exactly one way that we do this, but better not introduce one more way. Docs should be consistent.
Co-authored-by: Gal Topper <gal.topper@gmail.com>
Co-authored-by: Gal Topper <gal.topper@gmail.com>
…_target' into read_optimisation_on_partitioned_target
gtopper
reviewed
May 1, 2024
mlrun/datastore/base.py
Outdated
| @@ -550,6 +575,12 @@ def as_df( | |||
| :param end_time: filters out data after this time | |||
| :param time_column: Store timestamp_key will be used if None. | |||
| The results will be filtered by this column and start_time & end_time. | |||
| :param additional_filters: List of additional_filters conditions as tuples. | |||
There was a problem hiding this comment.
Suggested change
| :param additional_filters: List of additional_filters conditions as tuples. | |
| :param additional_filters: List of additional filter conditions as tuples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) In local_merger + dask_merger.
b) In ParquetSource.
c) In ParquetTarget.
d) get_offline_features and more.
ML-6161