Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Change v3io test chunks size #5467

Merged
merged 2 commits into from
May 5, 2024

Conversation

tomerm-iguazio
Copy link
Contributor

@tomerm-iguazio tomerm-iguazio commented Apr 28, 2024

Change Test chunks size for better test performance.

ML-5598

@gtopper gtopper changed the title [Tests] change v3io test chunks size. [Tests] Change v3io test chunks size Apr 28, 2024
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your word for it regarding the performance.

@assaf758
Copy link
Member

So just clarifying in pr #5468 the default chunk size was set to 10mb because it has optimal performance…
Why use 500KB chunks in the test? From your tests, it seems it would be much slower than the 10mb optimum…

@assaf758 assaf758 merged commit 9054377 into mlrun:development May 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants