[RemoteWorkflows] Fail fast when remote runner is failing [1.6.x] #5469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
approved these changes
Apr 30, 2024
TomerShor
changed the title
liranbg
added a commit
to liranbg/mlrun
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a remote workflow, the configuration might be incorrect causing the remote runner (the pod that spins the remote workflow) to fail before it spins the workflow at all.
This would lead to needlessly wait for the workflow to come up the entire timeout (300 seconds by default)
This PR introduces a fail-fast mechanism for remote workflows where it detects the remote runner status and once it fails, it returns 412 to client (a-la SDK) which stops immediately waiting for the remote workflow to be finished
https://iguazio.atlassian.net/browse/ML-6188