-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Monitoring] Improvements to mm-apps do_tracking API #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mlrun/model_monitoring/application.py # mlrun/model_monitoring/controller.py
jond01
reviewed
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I had a few comments about the docs, tests, and implementation.
tests/model_monitoring/test_applications/test_histogram_data_drift.py
Outdated
Show resolved
Hide resolved
Eyal-Danieli
reviewed
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Few comments and suggestions, mostly docstrings and typehints :)
Eyal-Danieli
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements - ML-6259.
ModelMonitoringApplicationBaseV2
:a. with new
do_tracing
signature.b. delete
self.context
and uses themonitoring_context
param as mlrun context.MonitoringApplicationContext
- The monitoring context holds all the relevant information for the monitoring application, and also it can be used for logging artifacts and results.EvidentlyModelMonitoringApplicationBaseV2
.__PrepareMonitoringEvent
step the application servinggraph
- preparing the application event for the application step._PushToWriter
step.HistogramDataDriftApplication
to v2.ModelMonitoringWriter
andModelMonitoringWriter._reconstruct_event
to work with 2 kinds of events -metric
andresult
, for now theModelMonitoringWriter
writes only the results to the databases.