[Notifications] Fix Slack Notifications With Long Messages #5489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 3, 2024 11:05
added 2 commits
May 2, 2024 11:36
liranbg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://iguazio.atlassian.net/browse/ML-6324
Slack notifications now use headers for making the notification message bold. However these header sections are limited to 150 characters. Any message longer than that resulted in a 400 Bad Request from slack servers.
Mostly this arose from Pipeline start notifications which contain a long url in them.
So now we truncate the header to the nearest
,or 150 characters, whichever comes first, and the rest is set in another section below the header.Attached are images showing before (only section, no header):
And after (section and header):
