[Feature store] Feature set api fixes #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code needed and unit tests for new functionality
Fixed listdir on root container, and rmeoved path from result names
…ture_set_api_fixes
- Added kind to the feature-set object (has to be "FeatureSet") - Added project to ObjectMetadata - Modified RunDBInterface to return dicts rather than schema objects - Fixed an issue with creating a feature-set without labels
Hedingber
suggested changes
Nov 24, 2020
Hedingber
changed the title
- Rename RunDB's update_feature_set to patch_feature_set - Changed FeatureSet kind schema field to an enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature-set API fixes and changes (as requested by @yaronha ):
kindto the feature-set object (value has to beFeatureSet)projecttoObjectMetadataRunDBInterfaceto return dicts rather than schema objects, so that client code doesn't need to do double-conversion to dict and then to the client-side schemastore_feature_setAPI now has default value for object name, so it can be called with just a feature-set and project/name will be deduced from the object metadata