Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProjectSummaries] Make _calculate_pipelines_counters use pagination #5496

Merged
merged 12 commits into from
May 3, 2024

Conversation

roei3000b
Copy link
Member

Fix bug in function _calculate_pipelines_counters - it ignored the return value of page_token from _list_pipelines and because of that if there were some pages, we only return the statistics for the first page.
Fixing it by using pagination in list_pipelines function.

https://iguazio.atlassian.net/browse/ML-6121

Copy link
Member

@rokatyy rokatyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added just one minor suggestion

server/api/crud/projects.py Outdated Show resolved Hide resolved
Copy link
Member

@liranbg liranbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a unit test

@roei3000b roei3000b requested a review from liranbg May 2, 2024 14:36
@liranbg liranbg merged commit 7ab5e43 into mlrun:development May 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants